docs: const name in the useMedia example#2024
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The code referenced a `video` variable that did exist in the example code (probably a copy-and-paste typo). the new code points to the `videoElement` const declared a few lines before.
✅ Deploy Preview for pinia-official ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
posva
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The example code referenced a
videovariable that did exist in the example code (probably a copy-and-paste typo). The new code points to thevideoElementconst declared a few lines before.Regarding "Please make sure to include a test! If this is closing an existing issue, reference that issue as well.", since it is a documentation update, I assume tests are not required.