Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(firefox): fix reload with hash URLs#21322

Merged
merged 3 commits into from Mar 2, 2023
Merged

fix(firefox): fix reload with hash URLs #21322

merged 3 commits into from Mar 2, 2023

Conversation

aslushnikov
Copy link
Collaborator

@aslushnikov aslushnikov commented Mar 2, 2023 •
edited

Fixes #21145

@aslushnikov
fix(firefox): fix reload with hash URLs
286fde2 
While this fixes the regression, this breaks the microsoft#20791.
We'll fix it separately.

Fixes microsoft#21145
@aslushnikov aslushnikov added the CQ1 label Mar 2, 2023
@aslushnikov
Copy link
Collaborator Author

Let's use rawEvaluateJSON

@aslushnikov aslushnikov added CQ1 and removed CQ1 labels Mar 2, 2023
@aslushnikov aslushnikov removed the CQ1 label Mar 2, 2023
@aslushnikov aslushnikov merged commit bfc8957 into microsoft:main Mar 2, 2023
@aslushnikov aslushnikov deleted the fix-problematic-reload branch March 2, 2023 02:56
aslushnikov added a commit that referenced this pull request Mar 2, 2023
@aslushnikov
cherry-pick(#21322): fix(firefox): fix reload with hash URLs
b9f4f2c 
Fixes #21145
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dgozman dgozman dgozman approved these changes
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[REGRESSION]: firefox-1378 times out on await page.reload() when URL contains a #hash
2 participants
@aslushnikov @dgozman