Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: have pretty error if CT config has no defineConfig#21318

Merged
merged 4 commits into from Mar 1, 2023
Merged

chore: have pretty error if CT config has no defineConfig #21318

merged 4 commits into from Mar 1, 2023

Conversation

mxschmitt
Copy link
Member

Fixes #21312

@mxschmitt mxschmitt force-pushed the throw-if-ct-without-define-config branch from 16a580e to 3f89053 Compare March 1, 2023 23:18
@mxschmitt @pavelfeldman
Update packages/playwright-test/src/mount.ts
c9cb68b 
Co-authored-by: Pavel Feldman <pavel.feldman@gmail.com>
Signed-off-by: Max Schmitt <max@schmitt.mx>
@mxschmitt
Update packages/playwright-test/index.js
6172466 
Signed-off-by: Max Schmitt <max@schmitt.mx>
@mxschmitt
nits
0456f5a
@mxschmitt mxschmitt merged commit 6a7347f into microsoft:main Mar 1, 2023
github-actions bot added a commit that referenced this pull request Mar 1, 2023
@github-actions
cherry-pick(#21318): chore: have pretty error if CT config has no def…
2b1d035 
…ineConfig
yury-s pushed a commit that referenced this pull request Mar 2, 2023
@playwrightmachine
cherry-pick(#21318): chore: have pretty error if CT config has no def…
d7ad0a0 
…ineConfig (#21321)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pavelfeldman pavelfeldman pavelfeldman approved these changes
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

throw if defineConfig is not used for component testing
2 participants
@mxschmitt @pavelfeldman