Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move RTCRtpEncodingParameters.maxFramerate to webrtc-pc#2785

Merged
merged 2 commits into from Oct 13, 2022

Conversation

Orphis
Copy link
Contributor

@Orphis Orphis commented Oct 13, 2022

It has been implemented in 3 UAs and deserves a promotion.


Preview | Diff

Copy link
Contributor

@aboba aboba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a link to the WPT test?

@Orphis
Copy link
Contributor Author

Orphis commented Oct 13, 2022

I can preemptively add a link to the tests that are not moved yet from the webrtc-extensions folder to webrtc-pc if that's what you mean.

@aboba
Copy link
Contributor

aboba commented Oct 13, 2022

Also I think you need to modify amendments.json

@dontcallmedom
Copy link
Member

@Orphis I'll take care of the amendments.json change since that one is a bit complicated

webrtc.html Outdated Show resolved Hide resolved
webrtc.html Outdated Show resolved Hide resolved
webrtc.html Show resolved Hide resolved
@alvestrand
Copy link
Contributor

@Orphis will work with @dontcallmedom to fix amendments.json

Orphis and others added 2 commits October 13, 2022 19:25
webrtc.js Show resolved Hide resolved
@dontcallmedom dontcallmedom merged commit 8a49acd into w3c:main Oct 13, 2022
dontcallmedom added a commit to dontcallmedom/web-platform-tests that referenced this pull request Nov 15, 2023
dontcallmedom added a commit to web-platform-tests/wpt that referenced this pull request Dec 5, 2023
moz-v2v-gh pushed a commit to mozilla/gecko-dev that referenced this pull request Dec 14, 2023
…amerate test into main webrtc…, a=testonly

Automatic update from web-platform-tests
Integrate RTCRtpEncodingParameters maxFramerate test into main webrtc folder (#43173)

per w3c/webrtc-pc#2785
--

wpt-commits: 37e24fab108ec20ee6091f05266875026609f393
wpt-pr: 43173
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified-and-comments-removed that referenced this pull request Dec 16, 2023
…amerate test into main webrtc…, a=testonly

Automatic update from web-platform-tests
Integrate RTCRtpEncodingParameters maxFramerate test into main webrtc folder (#43173)

per w3c/webrtc-pc#2785
--

wpt-commits: 37e24fab108ec20ee6091f05266875026609f393
wpt-pr: 43173

UltraBlame original commit: 58a38a023451c43f5733f594c24e0976d023ad06
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified that referenced this pull request Dec 16, 2023
…amerate test into main webrtc…, a=testonly

Automatic update from web-platform-tests
Integrate RTCRtpEncodingParameters maxFramerate test into main webrtc folder (#43173)

per w3c/webrtc-pc#2785
--

wpt-commits: 37e24fab108ec20ee6091f05266875026609f393
wpt-pr: 43173

UltraBlame original commit: 58a38a023451c43f5733f594c24e0976d023ad06
gecko-dev-updater pushed a commit to marco-c/gecko-dev-comments-removed that referenced this pull request Dec 16, 2023
…amerate test into main webrtc…, a=testonly

Automatic update from web-platform-tests
Integrate RTCRtpEncodingParameters maxFramerate test into main webrtc folder (#43173)

per w3c/webrtc-pc#2785
--

wpt-commits: 37e24fab108ec20ee6091f05266875026609f393
wpt-pr: 43173

UltraBlame original commit: 58a38a023451c43f5733f594c24e0976d023ad06
aosmond pushed a commit to aosmond/gecko that referenced this pull request Dec 16, 2023
…amerate test into main webrtc…, a=testonly

Automatic update from web-platform-tests
Integrate RTCRtpEncodingParameters maxFramerate test into main webrtc folder (#43173)

per w3c/webrtc-pc#2785
--

wpt-commits: 37e24fab108ec20ee6091f05266875026609f393
wpt-pr: 43173
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants