Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do all input validation upfront in setConfiguration.#2689

Merged
merged 1 commit into from Nov 4, 2021
Merged

Do all input validation upfront in setConfiguration. #2689

merged 1 commit into from Nov 4, 2021

Conversation

jan-ivar
Copy link
Member

@jan-ivar jan-ivar commented Oct 22, 2021 •
edited by pr-preview bot

Fixes #2688.

Preview | Diff

@jan-ivar jan-ivar self-assigned this Oct 22, 2021
@jan-ivar
Copy link
Member Author

fyi @docfaraday

@aboba aboba merged commit 9669d7e into w3c:main Nov 4, 2021
dontcallmedom added a commit that referenced this pull request Jan 28, 2022
@dontcallmedom
Document substantive changes since Rec as candidate amendments
f492d47 
Candidate amendments process: https://www.w3.org/2021/Process-20211102/#candidate-changes
PR covered based on https://github.com/w3c/webrtc-pc/pulls?q=is%3Apr++-label%3AEditorial+merged%3A%3E2021-01-01+ (merged PRs since Jan 1 2021): #2679 #2680 #2686 #2687 #2689 #2691 #2700 #2704 #2708
dontcallmedom added a commit that referenced this pull request May 5, 2022
@dontcallmedom
Document substantive changes since Rec as candidate amendments
47aa9a2 
Candidate amendments process: https://www.w3.org/2021/Process-20211102/#candidate-changes
PR covered based on https://github.com/w3c/webrtc-pc/pulls?q=is%3Apr++-label%3AEditorial+merged%3A%3E2021-01-01+ (merged PRs since Jan 1 2021): #2679 #2680 #2686 #2687 #2689 #2691 #2700 #2704 #2708
dontcallmedom added a commit that referenced this pull request Jul 19, 2022
@dontcallmedom
Document substantive changes since Rec as candidate amendments
bfaa022 
Candidate amendments process: https://www.w3.org/2021/Process-20211102/#candidate-changes
PR covered based on https://github.com/w3c/webrtc-pc/pulls?q=is%3Apr++-label%3AEditorial+merged%3A%3E2021-01-01+ (merged PRs since Jan 1 2021): #2679 #2680 #2686 #2687 #2689 #2691 #2700 #2704 #2708
dontcallmedom added a commit that referenced this pull request Aug 19, 2022
@dontcallmedom
Document substantive changes since Rec as candidate amendments
cfce609 
Candidate amendments process: https://www.w3.org/2021/Process-20211102/#candidate-changes
PR covered based on https://github.com/w3c/webrtc-pc/pulls?q=is%3Apr++-label%3AEditorial+merged%3A%3E2021-01-01+ (merged PRs since Jan 1 2021): #2679 #2680 #2686 #2687 #2689 #2691 #2700 #2704 #2708
dontcallmedom added a commit that referenced this pull request Sep 27, 2022
@dontcallmedom
Document substantive changes since Rec as candidate amendments
f1f939b 
Candidate amendments process: https://www.w3.org/2021/Process-20211102/#candidate-changes
PR covered based on https://github.com/w3c/webrtc-pc/pulls?q=is%3Apr++-label%3AEditorial+merged%3A%3E2021-01-01+ (merged PRs since Jan 1 2021): #2679 #2680 #2686 #2687 #2689 #2691 #2700 #2704 #2708
dontcallmedom added a commit to dontcallmedom/web-platform-tests that referenced this pull request Nov 15, 2023
@dontcallmedom
Add test for w3c/webrtc-pc#2689
1cfe3f7 
Ensure that an invalid rtcconfiguration doesn't get partially applied
dontcallmedom added a commit to web-platform-tests/wpt that referenced this pull request Nov 15, 2023
@dontcallmedom @alvestrand
Add test for w3c/webrtc-pc#2689 (#43167)
967eaa0 
* Add test for w3c/webrtc-pc#2689

Ensure that an invalid rtcconfiguration doesn't get partially applied

* Fix typo

Co-authored-by: Harald Alvestrand <hta+github@alvestrand.no>

---------

Co-authored-by: Harald Alvestrand <hta+github@alvestrand.no>
@dontcallmedom dontcallmedom mentioned this pull request Nov 15, 2023
Merged
23 tasks
moz-v2v-gh pushed a commit to mozilla/gecko-dev that referenced this pull request Nov 22, 2023
@dontcallmedom @moz-wptsync-bot
Bug 1864814 [wpt PR 43167] - Add test for w3c/webrtc-pc#2689, a=testonly
8d09a0f 
Automatic update from web-platform-tests
Add test for w3c/webrtc-pc#2689 (#43167)

* Add test for w3c/webrtc-pc#2689

Ensure that an invalid rtcconfiguration doesn't get partially applied

* Fix typo

Co-authored-by: Harald Alvestrand <hta+github@alvestrand.no>

---------

Co-authored-by: Harald Alvestrand <hta+github@alvestrand.no>
--

wpt-commits: 967eaa031cfe4039a18a7380899dbe3091d16cbe
wpt-pr: 43167
moz-v2v-gh pushed a commit to mozilla/gecko-dev that referenced this pull request Nov 22, 2023
@dontcallmedom @moz-wptsync-bot
Bug 1864814 [wpt PR 43167] - Add test for w3c/webrtc-pc#2689, a=testonly
8353815 
Automatic update from web-platform-tests
Add test for w3c/webrtc-pc#2689 (#43167)

* Add test for w3c/webrtc-pc#2689

Ensure that an invalid rtcconfiguration doesn't get partially applied

* Fix typo

Co-authored-by: Harald Alvestrand <hta+github@alvestrand.no>

---------

Co-authored-by: Harald Alvestrand <hta+github@alvestrand.no>
--

wpt-commits: 967eaa031cfe4039a18a7380899dbe3091d16cbe
wpt-pr: 43167
vinnydiehl pushed a commit to vinnydiehl/mozilla-unified that referenced this pull request Nov 24, 2023
@dontcallmedom @moz-wptsync-bot
Bug 1864814 [wpt PR 43167] - Add test for w3c/webrtc-pc#2689, a=testonly
d9e7115 
Automatic update from web-platform-tests
Add test for w3c/webrtc-pc#2689 (#43167)

* Add test for w3c/webrtc-pc#2689

Ensure that an invalid rtcconfiguration doesn't get partially applied

* Fix typo

Co-authored-by: Harald Alvestrand <hta+github@alvestrand.no>

---------

Co-authored-by: Harald Alvestrand <hta+github@alvestrand.no>
--

wpt-commits: 967eaa031cfe4039a18a7380899dbe3091d16cbe
wpt-pr: 43167
vinnydiehl pushed a commit to vinnydiehl/mozilla-unified that referenced this pull request Nov 24, 2023
@dontcallmedom @moz-wptsync-bot
Bug 1864814 [wpt PR 43167] - Add test for w3c/webrtc-pc#2689, a=testonly
cf3b7e1 
Automatic update from web-platform-tests
Add test for w3c/webrtc-pc#2689 (#43167)

* Add test for w3c/webrtc-pc#2689

Ensure that an invalid rtcconfiguration doesn't get partially applied

* Fix typo

Co-authored-by: Harald Alvestrand <hta+github@alvestrand.no>

---------

Co-authored-by: Harald Alvestrand <hta+github@alvestrand.no>
--

wpt-commits: 967eaa031cfe4039a18a7380899dbe3091d16cbe
wpt-pr: 43167
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified-and-comments-removed that referenced this pull request Nov 30, 2023
@marco-c
Bug 1864814 [wpt PR 43167] - Add test for w3c/webrtc-pc#2689, a=testonly
b29f7b7 
Automatic update from web-platform-tests
Add test for w3c/webrtc-pc#2689 (#43167)

* Add test for w3c/webrtc-pc#2689

Ensure that an invalid rtcconfiguration doesn't get partially applied

* Fix typo

Co-authored-by: Harald Alvestrand <hta+githubalvestrand.no>

---------

Co-authored-by: Harald Alvestrand <hta+githubalvestrand.no>
--

wpt-commits: 967eaa031cfe4039a18a7380899dbe3091d16cbe
wpt-pr: 43167

UltraBlame original commit: 85834bf43183a95724d1cb506f4bab06001cec6f
gecko-dev-updater pushed a commit to marco-c/gecko-dev-comments-removed that referenced this pull request Nov 30, 2023
@marco-c
Bug 1864814 [wpt PR 43167] - Add test for w3c/webrtc-pc#2689, a=testonly
cd8d54d 
Automatic update from web-platform-tests
Add test for w3c/webrtc-pc#2689 (#43167)

* Add test for w3c/webrtc-pc#2689

Ensure that an invalid rtcconfiguration doesn't get partially applied

* Fix typo

Co-authored-by: Harald Alvestrand <hta+githubalvestrand.no>

---------

Co-authored-by: Harald Alvestrand <hta+githubalvestrand.no>
--

wpt-commits: 967eaa031cfe4039a18a7380899dbe3091d16cbe
wpt-pr: 43167

UltraBlame original commit: 85834bf43183a95724d1cb506f4bab06001cec6f
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified that referenced this pull request Nov 30, 2023
@marco-c
Bug 1864814 [wpt PR 43167] - Add test for w3c/webrtc-pc#2689, a=testonly
b7cd60c 
Automatic update from web-platform-tests
Add test for w3c/webrtc-pc#2689 (#43167)

* Add test for w3c/webrtc-pc#2689

Ensure that an invalid rtcconfiguration doesn't get partially applied

* Fix typo

Co-authored-by: Harald Alvestrand <hta+githubalvestrand.no>

---------

Co-authored-by: Harald Alvestrand <hta+githubalvestrand.no>
--

wpt-commits: 967eaa031cfe4039a18a7380899dbe3091d16cbe
wpt-pr: 43167

UltraBlame original commit: 85834bf43183a95724d1cb506f4bab06001cec6f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alvestrand alvestrand Awaiting requested review from alvestrand

@aboba aboba Awaiting requested review from aboba

@youennf youennf Awaiting requested review from youennf
Assignees

@jan-ivar jan-ivar

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

pc.setConfiguration() has an input validation order bug
2 participants
@jan-ivar @aboba