Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RTCPeerConnectionState and RTCIceConnectionState computation should consider sctp transport#2680

Merged
merged 3 commits into from Oct 7, 2021
Merged

RTCPeerConnectionState and RTCIceConnectionState computation should consider sctp transport #2680

merged 3 commits into from Oct 7, 2021

Conversation

youennf
Copy link
Contributor

@youennf youennf commented Oct 7, 2021 •
edited by pr-preview bot

@youennf
Copy link
Contributor Author

youennf commented Oct 7, 2021

Fixes #2677

@alvestrand
Copy link
Contributor

Needs to refer to all 3 usages of "set of transports", otherwise LGTM.

@paweldomas
Copy link

Doesn't SCTP run on top of ice?

@alvestrand
Copy link
Contributor

Doesn't SCTP run on top of ice?

it does, but we do have the option of either using the same transport or a different transport.

@alvestrand alvestrand merged commit 376174b into w3c:main Oct 7, 2021
@dontcallmedom
Copy link
Member

for record keeping, this was merged under the "pure bug fix" category of https://github.com/w3c/webrtc-charter/blob/gh-pages/merge-guide.md#changes-that-bypass-the--extensions-stage, correct?

@youennf youennf mentioned this pull request Oct 21, 2021
Closed
dontcallmedom added a commit that referenced this pull request Jan 28, 2022
@dontcallmedom
Document substantive changes since Rec as candidate amendments
f492d47 
Candidate amendments process: https://www.w3.org/2021/Process-20211102/#candidate-changes
PR covered based on https://github.com/w3c/webrtc-pc/pulls?q=is%3Apr++-label%3AEditorial+merged%3A%3E2021-01-01+ (merged PRs since Jan 1 2021): #2679 #2680 #2686 #2687 #2689 #2691 #2700 #2704 #2708
dontcallmedom added a commit that referenced this pull request May 5, 2022
@dontcallmedom
Document substantive changes since Rec as candidate amendments
47aa9a2 
Candidate amendments process: https://www.w3.org/2021/Process-20211102/#candidate-changes
PR covered based on https://github.com/w3c/webrtc-pc/pulls?q=is%3Apr++-label%3AEditorial+merged%3A%3E2021-01-01+ (merged PRs since Jan 1 2021): #2679 #2680 #2686 #2687 #2689 #2691 #2700 #2704 #2708
dontcallmedom added a commit that referenced this pull request Jul 19, 2022
@dontcallmedom
Document substantive changes since Rec as candidate amendments
bfaa022 
Candidate amendments process: https://www.w3.org/2021/Process-20211102/#candidate-changes
PR covered based on https://github.com/w3c/webrtc-pc/pulls?q=is%3Apr++-label%3AEditorial+merged%3A%3E2021-01-01+ (merged PRs since Jan 1 2021): #2679 #2680 #2686 #2687 #2689 #2691 #2700 #2704 #2708
dontcallmedom added a commit that referenced this pull request Aug 19, 2022
@dontcallmedom
Document substantive changes since Rec as candidate amendments
cfce609 
Candidate amendments process: https://www.w3.org/2021/Process-20211102/#candidate-changes
PR covered based on https://github.com/w3c/webrtc-pc/pulls?q=is%3Apr++-label%3AEditorial+merged%3A%3E2021-01-01+ (merged PRs since Jan 1 2021): #2679 #2680 #2686 #2687 #2689 #2691 #2700 #2704 #2708
dontcallmedom added a commit that referenced this pull request Sep 27, 2022
@dontcallmedom
Document substantive changes since Rec as candidate amendments
f1f939b 
Candidate amendments process: https://www.w3.org/2021/Process-20211102/#candidate-changes
PR covered based on https://github.com/w3c/webrtc-pc/pulls?q=is%3Apr++-label%3AEditorial+merged%3A%3E2021-01-01+ (merged PRs since Jan 1 2021): #2679 #2680 #2686 #2687 #2689 #2691 #2700 #2704 #2708
@dontcallmedom dontcallmedom mentioned this pull request Nov 15, 2023
Merged
23 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jan-ivar jan-ivar jan-ivar approved these changes
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet

5 participants
@youennf @alvestrand @paweldomas @dontcallmedom @jan-ivar