Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lastModifiedDate on File is not a thing#215

Closed
inexorabletash opened this issue Sep 20, 2017 · 6 comments · Fixed by #300
Closed

lastModifiedDate on File is not a thing #215

inexorabletash opened this issue Sep 20, 2017 · 6 comments · Fixed by #300
Labels
needs-pr
Milestone
V3

Comments

@inexorabletash
Copy link
Member

There's a clause for evaluating keypaths on File objects with the "lastModifiedDate" property. That property is only implemented in some browsers (Chrome, Firefox, maybe Edge?, but not Safari) but is not in the https://w3c.github.io/FileAPI/ standard.

This should be reconciled - either spec it or remove it from IDB.
@inexorabletash
Copy link
Member Author

This is also covered in test that should be updated appropriately:

https://github.com/w3c/web-platform-tests/blob/master/IndexedDB/keypath-special-identifiers.htm#L43

@inexorabletash inexorabletash added this to the V3 milestone Sep 20, 2017
@inexorabletash
Copy link
Member Author

It looks like Firefox has managed to unship lastModifiedDate (or my note was wrong).

@inexorabletash
Copy link
Member Author

HTTPArchive searches are pretty much useless here since it's very common property name used by developers (e.g. JIRA records). We'll need to instrument in Chrome to determine usage.

@mkruisselbrink
Copy link

Are you looking for usage of File.lastModifiedDate in general, or about its usage in IndexedDB specifically? The first one is measured in https://www.chromestatus.com/metrics/feature/timeline/popularity/212 (and removal tracked in https://crbug.com/692728)

(and the chrome bug does indeed mention that Firefox was going to remove lastModifiedDate in FF 61)

@inexorabletash
Copy link
Member Author

TPAC 2019 Web Apps Indexed DB triage notes:

Delete it from the spec, then it's just a Chrome problem. Good luck, Chrome. (Oh wait....)

@asutherland
Copy link
Collaborator

The Firefox timeline on this is:

@inexorabletash inexorabletash mentioned this issue Sep 23, 2019
Merged
inexorabletash added a commit that referenced this issue Sep 24, 2019
@inexorabletash
Remove lastModifiedDate handling. (#300)
2bc2e3c 
Several browsers used to implement a nonstandard lastModifiedDate property on File objects. This has been removed everywhere except Chrome, and it's not in the File API spec. This specification included special cases for keypath evaluation of that property name, and it wasn't tested. Remove the references.

Closes #215
@inexorabletash inexorabletash mentioned this issue Sep 28, 2020
Closed
inexorabletash added a commit that referenced this issue Feb 1, 2021
@inexorabletash
Remove lastModifiedDate handling. (#300)
aa3c842 
Several browsers used to implement a nonstandard lastModifiedDate property on File objects. This has been removed everywhere except Chrome, and it's not in the File API spec. This specification included special cases for keypath evaluation of that property name, and it wasn't tested. Remove the references.

Closes #215
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
needs-pr
Projects
None yet
Milestone
V3
Development

Successfully merging a pull request may close this issue.

Remove lastModifiedDate handling w3c/IndexedDB
3 participants
@mkruisselbrink @asutherland @inexorabletash