Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consistent formatting of ISSN text#2953

Merged
merged 1 commit into from Apr 6, 2023
Merged

Consistent formatting of ISSN text #2953

merged 1 commit into from Apr 6, 2023

Conversation

edent
Copy link
Contributor

@edent edent commented Sep 7, 2021

Fixes #2952

@edent edent changed the title Consisten formatting of ISSN text Consistent formatting of ISSN text Sep 7, 2021
Copy link
Contributor

@danbri danbri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. It feels a little like over-reach on the part of the BL to be saying how people lay out their page. If you were using a bulleted list with foo: bar colons for everything else, writing "ISSN:" instead of "ISSN" seems reasonable, for example. If the string beginning "ISSN" is intended as a computer format, that would be a different matter. Interesting that they insist on the string appearing even in non-latin script language countries, eg. Japan: https://www.ndl.go.jp/en/data/issn/index.html

All that aside, thanks for the edit @edent :) BTW I followed your example a couple weeks ago and applied for an ISSN for my own (much neglected) blog, and it arrived within a few days.

@RichardWallis
Copy link
Contributor

See issue #2992.

The code in the branch behind this PR needs rebasing against the main branch in the schemaorg repository. This will enable it to pass the CI tests which it currently fails.

cc @edent

@github-actions
Copy link

This pull request is being nudged due to inactivity.

@github-actions github-actions bot added the no-pr-activity Discuss has gone quiet. Auto-tagging to encourage people to re-engage with the issue (or close it!). label Feb 16, 2022
@RichardWallis RichardWallis merged commit 56cce1c into schemaorg:main Apr 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-pr-activity Discuss has gone quiet. Auto-tagging to encourage people to re-engage with the issue (or close it!).
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ISSN example goes against guidance
3 participants