Example fixes#199
Example fixes #199
Conversation
… URI validation regexp to hang!)
…oObject, not VideoGame.
…nnecessary in markup.
…ntent to properly parse the Duration value.
…ot a property of VideoGameSeries.
… to a span and removed " Pages" from JSON-LD.
… to "seller" and "Organization".
|
@danbri if there's a better place for this PR to go, let me know. I may continue updating the PR with new example fixes until then. |
|
Just to say a huge thanks for doing these. There's a bit of administrivia to do first before integrating but ... thanks - much appreciated :) |
danbri
added
guidelines docs examples
|
Ok I've merged in #260 ... can we close this version? I made the %20 tweak afterwards. Suggestions for better workflow welcomed - would you prefer I ask the original pull request to be reconfigured to another branch? in this case I wanted it against sdo-stantz rather than master branch, and it seemed easier just to make another quick pull request. I couldn't see a way to change this one myself. |
|
You cannot change the target branch once the pull request is created, you have to create a new one, as inconvenient as it is... What if you set the default branch and adjusted it accordingly after each release? https://help.github.com/articles/setting-the-default-branch/ - pull requests will be created against that branch by default. |
|
Thanks @scor just what I was looking for! :) |
|
Related - I've updated #53 with a link to the results of re-running this linter against today's version of sdo-stantz: https://gist.github.com/danbri/c5fef76dcf89bc23bdb6 |
I went through and fixed many examples, one of which was actually causing my RDFa processor to hang! Everything else should be non-controversial, but there are some issues that indicate properties might be misnamed.
There are many more markup issues, and it would be great if new examples passed some form of validation before being incorporated. These were identified using a command-line tool in the linter.