Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a new property to support color swatches#3423

Closed
alex-jansen opened this issue Dec 14, 2023 · 6 comments
Closed

Add a new property to support color swatches #3423

alex-jansen opened this issue Dec 14, 2023 · 6 comments
Assignees
@alex-jansen
Labels
no-issue-activity Discuss has gone quiet. Auto-tagging to encourage people to re-engage with the issue (or close it!).

Comments

@alex-jansen
Copy link
Contributor

Context - This is a proposal from Google based on our experience consuming schema.org Product markup and working with similar data from online merchants. If it were accepted, it would make it easier for us and others to understand the colors of products sold online.

Proposal - Schema.org supports the specification of product colors through property color of type Text. A disadvantage of only allowing a free-form textual description of a color is that it provides a lot of room for interpretation. For example "Charcoal" and "Ash" are both shades of the color Gray, but it is hard for a user to understand the difference just based on the textual description. Many popular apparel websites therefore show a color swatch image together with the color name to allow the user to visualize the color of a product variant.

Given the common use of color swatches in the industry we propose to add a new colorSwatch property as sub-property of image with values of type URL or ImageObject.
@alex-jansen alex-jansen self-assigned this Dec 14, 2023
@Tiggerito
Copy link

In the platform I work on a color swatch is just the HTML color code. like ff0000. Would there be any way to support that?

@alex-jansen
Copy link
Contributor Author

We could look into that as part of the color attribute. One of the things to consider here is that we often see apparel colors described as combinations, for example "black white colorblock", which cannot be described with a single color code.

@Tiggerito
Copy link

Would an array of the colors involved make sense?

How about having color support better parsing of the text content to recognise hex codes, URLs and finally a plain text description. Or even have extra types for the color property to formally indicate an image or hex code or other another color system for it?

@alex-jansen
Copy link
Contributor Author

Good ideas, although I also think representing colors is probably a different (and complex!) topic for which we should maybe revive #938? For example, we could follow standard color code lists (see for example gs1:ColourCodeListCode, which seems to be a common industry practice.

alex-jansen added a commit that referenced this issue Jan 5, 2024
@alex-jansen
add colorSwatch property (#3423)
70e1719
@alex-jansen alex-jansen mentioned this issue Jan 5, 2024
Closed
danbri pushed a commit that referenced this issue Jan 15, 2024
@alex-jansen
Add Certification class (#3230) (#3441)
51121ce 
* add colorSwatch property (#3423)

* add new return method KeepProduct, #2880

* add Certification class #3230

* add logo to Certification

* renumber Certification examples due to numbering clash

* fix a build error conflict in Certification examples. Temp workaround
@github-actions GitHub Actions
Copy link

This issue is being nudged due to inactivity.

@github-actions github-actions bot added the no-issue-activity Discuss has gone quiet. Auto-tagging to encourage people to re-engage with the issue (or close it!). label Mar 21, 2024
@alex-jansen
Copy link
Contributor Author

This was added to release 25.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alex-jansen alex-jansen

Labels
no-issue-activity Discuss has gone quiet. Auto-tagging to encourage people to re-engage with the issue (or close it!).
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests

2 participants
@Tiggerito @alex-jansen