Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improved unit-testing code.#3348

Merged
merged 1 commit into from Jul 18, 2023
Merged

Improved unit-testing code. #3348

merged 1 commit into from Jul 18, 2023

Conversation

MatthiasWiesmann
Copy link
Contributor

  • Prettier display (color) when outputing to terminal. This uses the colorama package which is already a requirement.
  • All tests are now defined in terms of unit-tests.
  • Use the unit-testing framework skip facility to indicate when a test is skipped.

@MatthiasWiesmann
Improved unit-testing code.
d38e9ca 
* Prettier display (color) when outputing to terminal.
  This uses the `colorama` package which is already a requirement.
* All tests are now defined in terms of unit-tests.
* Use the unit-testing framework skip facility to indicate when a test is skipped.
@danbri
Copy link
Contributor

danbri commented Jul 14, 2023

Lgtm

@RichardWallis - any reason not to commit this that I might be overlooking?

@RichardWallis
Copy link
Contributor

@danbri On the surface no, but it needs checking out as its not just a couple lines of change.

@RichardWallis RichardWallis merged commit ad107c1 into schemaorg:main Jul 18, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet

3 participants
@MatthiasWiesmann @danbri @RichardWallis