Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Broken link in the description of /DeliveryTImeSettings#2622

Closed
alex-jansen opened this issue Jul 2, 2020 · 2 comments
Closed

Broken link in the description of /DeliveryTImeSettings #2622

alex-jansen opened this issue Jul 2, 2020 · 2 comments
Assignees
@alex-jansen

Comments

@alex-jansen
Copy link
Contributor

Link to "OfferShippingSpecification" is broken, it should be "OfferShippingDetails"
@alex-jansen alex-jansen self-assigned this Jul 2, 2020
@danbri
Copy link
Contributor

danbri commented Jul 2, 2020

thanks for catching this

@alex-jansen
Copy link
Contributor Author

Same broken link also in the /freeShippingThreshold description

alex-jansen added a commit that referenced this issue Jul 2, 2020
@alex-jansen
fix broken link (issue #2622)
ee8bc64
danbri pushed a commit that referenced this issue Jul 7, 2020
@alex-jansen
Fix Issue#2629 (#2630)
f8188be 
* fix broken link (issue #2622)

* Change /cutoffTime type from Text to Time

* add property isUnlabelledFallback to class DeliveryTimeSettings

* fix issue #2629
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alex-jansen alex-jansen

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests

2 participants
@danbri @alex-jansen