Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add vocabulary for describing vehicles / automobiles / automotive#262

Closed
danbri opened this issue Jan 22, 2015 · 13 comments
Closed

Add vocabulary for describing vehicles / automobiles / automotive #262

danbri opened this issue Jan 22, 2015 · 13 comments
Assignees
@danbri
Labels
schema.org vocab General top level tag for issues on the vocabulary
Milestone
sdo-ganymede release

Comments

@danbri
Copy link
Contributor

danbri commented Jan 22, 2015

http://schema.org/Car
http://schema.org/Vehicle

A substantial and detailed proposal has been prepared by Martin Hepp, see associated pull request: #80

Announcement / discussion: http://lists.w3.org/Archives/Public/public-vocabs/2014Dec/0057.html

Original W3C wiki link https://www.w3.org/wiki/WebSchemas/Vehicles

See 2015-01-09 review from @tmarshbing which suggests amongst other things partitioning the proposal into smaller sections.

See also #263 for the property-value proposal, which supports the proposal.
@danbri danbri added schema.org vocab General top level tag for issues on the vocabulary status:needs review labels Jan 22, 2015
@danbri danbri self-assigned this Jan 22, 2015
@danbri danbri changed the title Add vocabulary for describing vehicles / automobiles Add vocabulary for describing vehicles / automobiles / automotive Jan 29, 2015
@danbri danbri mentioned this issue Jan 29, 2015
Closed
@mfhepp mfhepp mentioned this issue Mar 13, 2015
Merged
@mfhepp
Copy link
Contributor

mfhepp commented Mar 13, 2015

I have just created a pull request

#379

that is a trimmed-down version of the automotive part of the original proposal and addresses the comments received in the meantime.

@mfhepp
Copy link
Contributor

mfhepp commented Mar 13, 2015

Note that we need #263 (Property-Values) for this proposal to be consistent, because the unitText property is referenced but not contained in this pull request.

@danbri danbri added this to the sdo-gozer release milestone May 5, 2015
@danbri
Copy link
Contributor Author

danbri commented May 5, 2015

http://www.fileformat.info/info/unicode/char/1f697/automobile.svg

@mfhepp
Copy link
Contributor

mfhepp commented May 5, 2015

Is the logo for the respective blogpost ;-) ?

danbri added a commit that referenced this issue May 12, 2015
@danbri
Partitioned Auto vocabulary into core + ext/ (latter queued for later).
e35b240 
Commented out keywords in the examples file for now, pending review/update of that.
Addresses #262
@danbri
Copy link
Contributor Author

danbri commented May 12, 2015

This is partially queued up for sdo-gozer and partially coming later as an extension. I'll therefore leave the issue open and update the milestone.

See http://sdo-gozer.appspot.com/docs/releases.html#automotive

@danbri danbri modified the milestones: 2015 Q2, sdo-gozer release May 12, 2015
danbri added a commit that referenced this issue May 13, 2015
@danbri
Updated with some missing automotive vocabulary that was supposed to …
f1eaf07 
…be included in Core.

Summary:

properties:

bodyType
vehicleIdentificationNumber (vin)
cargoVolume
vehicleConfiguration (was configuration)
knownVehicleDamages (was damages)
dateVehicleFirstRegistered (was dateFirstRegistered ) DISCUSS
doors (added as numberOfDoors)
driveWheelConfiguration
fuelType
vehicleInteriorColor (was interiorColor)
vehicleInteriorType (was interiorType)
mileageFromOdometer
vehicleModelDate (was modelDate)
numberOfPreviousOwners (was previousOwners)
productionDate ( generalized: "e.g." vehicle, added broader domain Product)
purchaseDate (generalized similarly)
vehicleSeatingCapacity (seatingCapacity)
vehicleTransmission (originally transmission)
steeringPosition
vehicleSpecialUsage (was specialUsage )

type:
CarUsageType

enums:
RentalVehicleUsage, RentalVehicleUsage, DrivingSchoolVehicleUsage, TaxiVehicleUsage

See also #262

Note that some of these renamings or definition tweaks were not fully discussed with
Martin Hepp, although from our prior discussions I believe they ought to be uncontroversial.

The reason for the tweaks is that we are trying to avoid using generic term names for
specific meanings. Therefore we either add more context into the term name, or soften the
definition to be applicable in more situations. In this case we have mostly made the terms
more specific.

/cc @tmarshbing @vholland
@danbri
Copy link
Contributor Author

danbri commented May 13, 2015

Q: I see "Typical unit code(s): C62" in several definitions but don't understand this. Searching around it seems to be in the original OWL ontology from @mfhepp too, so I don't think I introduced it in error.

@mfhepp
Copy link
Contributor

mfhepp commented May 13, 2015

C62 is the correct un/cefact common code for "piece" or "no unit".

martin

martin hepp
www: http://www.heppnetz.de/
email: mhepp@computer.org

On 13.05.2015, at 22:30, Dan Brickley notifications@github.com wrote:

Q: I see "Typical unit code(s): C62" in several definitions but don't understand this. Searching around it seems to be in the original OWL ontology from @mfhepp too, so I don't think I introduced it in error.

—
Reply to this email directly or view it on GitHub.

@danbri
Copy link
Contributor Author

danbri commented May 13, 2015

Ah, thanks.

I thought you were up a mountain!

We made some last minute tweaks but http://schema.org/Car is live. Can you take a quick look? The tweaks were all in the direction discussed previously, i.e. avoiding "using up" generic terms for vehicle-specific concepts. Mostly the changes were to names to indicate the vehicle scope, although in a couple of places they're slightly broadened (to Product). See f1eaf07 for a summary.

@jvandriel
Copy link

"I thought you were up a mountain!"

Can't we leave the man alone for one week? ;)

@mfhepp
Copy link
Contributor

mfhepp commented May 19, 2015

If this is not considered too specific a topic, it could be added to the FAQs - what do you think?

@danbri
Copy link
Contributor Author

danbri commented May 19, 2015

We have a fairly weak high-level overview of all our vocabulary at http://schema.org/docs/schemas.html (and linked from navigation toolbar on each page). I'd suggest updating that would be more useful.

Re FAQ I am also thinking to create a "technical FAQ" with some details in, e.g. url/URL,sameAs, mainEntity...

@mfhepp
Copy link
Contributor

mfhepp commented May 19, 2015

I think we should close this issue and continue work on the automotive extension part as #509

@mfhepp mfhepp mentioned this issue May 19, 2015
Open
@danbri
Copy link
Contributor Author

danbri commented May 19, 2015

Agreed. -> #509

@danbri danbri closed this as completed May 19, 2015
@danbri danbri mentioned this issue Jun 20, 2016
Closed
chrux added a commit to chrux/cars-agency-api that referenced this issue Aug 16, 2017
@chrux
Improving Car modeling.
15493f4 
We are trying to use schema.org/Car (repo schemaorg/schemaorg#262) and include trim https://www.quora.com/What-does-LXI-VXI-ZXI-mean-in-cars
@chrux chrux mentioned this issue Aug 16, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@danbri danbri

Labels
schema.org vocab General top level tag for issues on the vocabulary
Projects
None yet
Milestone
sdo-ganymede release
Development

No branches or pull requests

3 participants
@danbri @mfhepp @jvandriel