Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

numberOfRooms not a property for Type Hotel#2184

Closed
RichardWallis opened this issue Mar 28, 2019 · 2 comments
Closed

numberOfRooms not a property for Type Hotel #2184

RichardWallis opened this issue Mar 28, 2019 · 2 comments
Labels
Fixed Awaiting Release Fixed in main branch / posted to webschemas.org site / proposed for inclusion in next release

Comments

@RichardWallis
Copy link
Contributor

RichardWallis commented Mar 28, 2019 •
edited

Whilst checking examples it was identified that the numberOfRooms property does not have Hotel, or one of its super-types, in its domainIncludes.

As per the examples numberOfRooms makes sense as a property for Hotel. The assumption being that this is an oversight.

There is more than one way to solve this:

  1. Add Hotel to the domainIncludes of numberOfRooms

  2. Add LodgingBusiness to the domainIncludes of numberOfRooms. This may solve the same issue for other LodgingBusiness subtypes.

  3. Add Accommodation as a further super-type of Hotel.

/cc @mfhepp
@MichaelAndrews-RM
Copy link

Thinking about this extensibly, numberOfRooms could also be a property of a house for sale. If that were ever a use case to support, wouldn't want it limited to rental-oriented entities.

@RichardWallis
Copy link
Contributor Author

House & Apartment are subtypes of Accommodation which numberOfRooms has in its rangeIncludes. So for a house/apartment for sale scenario it is already there.

RichardWallis added a commit that referenced this issue Apr 10, 2019
@RichardWallis
Add LodgingBusiness to rangeIncludes of numberOfRooms
eae7942 
To address issue #2184
@RichardWallis RichardWallis mentioned this issue Apr 10, 2019
Merged
danbri pushed a commit that referenced this issue Apr 18, 2019
@RichardWallis @danbri
Add LodgingBusiness to rangeIncludes of numberOfRooms (#2204)
b00f9dc 
To address issue #2184
@RichardWallis RichardWallis added the Fixed Awaiting Release Fixed in main branch / posted to webschemas.org site / proposed for inclusion in next release label Apr 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Fixed Awaiting Release Fixed in main branch / posted to webschemas.org site / proposed for inclusion in next release
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests

2 participants
@MichaelAndrews-RM @RichardWallis