Fix serverside SetEnv inside Match blocks#201
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add the setenv array to the sub-config copy macro.
manuelm
changed the title
|
Thanks, I have merged the first commit (via our OpenBSD upstream) but not the second. I think ignoring previous successful setenv causes Match block setenv to be appended to ones set in the global configuration rather than the desired behaviour of overriding them. I need to think about it a little more.... |
|
It turns out that the first patch alone is sufficient to fix SetEnv inside match, as parse_server_match_config() always works on a new, empty ServerOptions object. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that serverside
SetEnvkeywords insideMatchblocks isn't working. Looking at the commit history (2801375) it looks like adding the array to copy macro simply has been forgotten.Further more it seems multiple statements inside the same context are not supported for no apparent reason. So I removed that as well.