Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set fetch-depth: 0 for actions/checkout in CI pipeline#218

Merged
merged 1 commit into from Nov 20, 2023

Conversation

qasimwarraich
Copy link
Contributor

@qasimwarraich qasimwarraich commented Nov 19, 2023

This should add the missing changelog. Seems like a fetch-depth of 0 needs to be set for the action to work properly. This is mentioned here in the docs for the goreleaser-action.

I setup a little test repo to test these changes out. Feel free to take a look:
CI workflow file
Releases w/ changelog

Resolves: #217

@miekg miekg merged commit a10759d into mmarkdown:master Nov 20, 2023
1 check passed
@miekg
Copy link
Contributor

miekg commented Nov 20, 2023

i don't see how a fetch depth of 0 will allow you to create a changelog containing previous commits, though?

@qasimwarraich
Copy link
Contributor Author

I believe it has to do with actions/checkout performing a shallow clone of the repo.

From the actions/checkout README:

Only a single commit is fetched by default, for the ref/SHA that triggered the workflow. Set fetch-depth: 0 to fetch all history for all branches and tags. Refer here to learn which commit $GITHUB_SHA points to for different events.

@qasimwarraich qasimwarraich deleted the ci/fix-for-release-notes branch November 20, 2023 09:28
@miekg
Copy link
Contributor

miekg commented Nov 20, 2023 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Provide release notes
2 participants