Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #201247 (Integrated Terminal does not set the environment variables from default profile)#209711

Merged
merged 2 commits into from
Apr 8, 2024
Merged

Fix #201247 (Integrated Terminal does not set the environment variables from default profile) #209711

merged 2 commits into from
Apr 8, 2024

Conversation

r-sargento
Copy link
Contributor

Fix #201247
The bug was caused because, SLC was only updating icon and color. Just added 2 lines to also get env.
Also made a new unit test, which uses a MockTerminalProfileResolver to always return a default profile with a specific env. Then I create the TerminalInstance, after that I wait for the _xtermReadyPromisse to resolve and after that I check if the env is in the SLC. Also had to add some _register in TerminalInstance to fix some leaks

@r-sargento
Copy link
Contributor Author

@r-sargento please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.

@microsoft-github-policy-service agree [company="{your company}"]

Options:

  • (default - no company specified) I have sole ownership of intellectual property rights to my Submissions and I am not making Submissions in the course of work for my employer.
@microsoft-github-policy-service agree
  • (when company given) I am making Submissions in the course of work for my employer (or my employer has intellectual property rights in my Submissions by contract or applicable law). I have permission from my employer to make Submissions and enter into this Agreement on behalf of my employer. By signing below, the defined term “You” includes me and my employer.
@microsoft-github-policy-service agree company="Microsoft"

Contributor License Agreement

@microsoft-github-policy-service agree

@r-sargento r-sargento changed the title Fix #201247 Fix #201247 (Integrated Terminal does not set the environment variables from default profile) Apr 6, 2024
@meganrogge meganrogge added this to the April 2024 milestone Apr 8, 2024
meganrogge
meganrogge approved these changes Apr 8, 2024
View reviewed changes
Copy link
Contributor

@meganrogge meganrogge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, it works well

@Tyriar Tyriar enabled auto-merge April 8, 2024 17:35
@Tyriar Tyriar merged commit 83856c3 into microsoft:main Apr 8, 2024
6 checks passed
Tyriar added a commit that referenced this pull request Apr 8, 2024
@Tyriar
Simplify tests added in #209711
5d251f3
Tyriar added a commit that referenced this pull request Apr 8, 2024
@Tyriar
Merge pull request #209875 from microsoft/tyriar/test_simpl
fa4588b 
Simplify tests added in #209711
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tyriar Tyriar Tyriar approved these changes

@meganrogge meganrogge meganrogge approved these changes
Assignees

@meganrogge meganrogge

Labels
None yet
Projects
None yet
Milestone
April 2024
Development

Successfully merging this pull request may close these issues.

"Open in Integrated Terminal" does not set the environment variables of the profile
3 participants
@r-sargento @Tyriar @meganrogge