I think we should use a separate api token named for this view. We may have additional clients of the APIs in the future, and we should be able to make the decision to limit one of the other of these endpoints from those additional clients.

The functionality looks fine. The list of groups to scrape from should get leadership review (I expect we will add groups and group types to it), but that does not have to happen now.

I think I'm done now. In addition to straightening out the API token reuse, I realized I'd deviated from the pattern used for the last few API endpoints. I've refactored to do the Group-specific work in ietf.group.utils.role_holder_emails() and put the API-specific interface in ietf.api.views.role_holder_addresses().

May not be perfect, but it's at least consistent.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.83%. Comparing base (187c2c5) to head (d2f81a3).
Report is 92 commits behind head on main.

@@            Coverage Diff             @@
##             main    #7291      +/-   ##
==========================================
- Coverage   88.98%   88.83%   -0.15%     
==========================================
  Files         291      291              
  Lines       40717    40881     +164     
==========================================
+ Hits        36233    36318      +85     
- Misses       4484     4563      +79     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.