Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Exclude replaced documents from IESG discusses#7258

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: Exclude replaced documents from IESG discusses #7258

wants to merge 1 commit into from
+1 −0

Conversation

pselkirk
Copy link
Collaborator

Fixes #7179

@codecov Codecov
Copy link

codecov bot commented Mar 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.84%. Comparing base (187c2c5) to head (421994f).
Report is 79 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7258      +/-   ##
==========================================
- Coverage   88.98%   88.84%   -0.15%     
==========================================
  Files         291      291              
  Lines       40717    41102     +385     
==========================================
+ Hits        36233    36516     +283     
- Misses       4484     4586     +102

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

rjsparks
rjsparks requested changes Mar 26, 2024
View reviewed changes
Copy link
Member

@rjsparks rjsparks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is good (though it could be simplified to chain the exclude onto the existing statement, and the whole statement could benefit from being processed by black.)

But there should be a test that proves it. I suspect it will be a small adjustment to an existing test.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rjsparks rjsparks rjsparks requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Replaced documents show on https://datatracker.ietf.org/iesg/discusses/ - they shouldn't.
2 participants
@pselkirk @rjsparks