Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: avoid confusing gray color for Add to calendar in the agenda#7210

Merged
merged 1 commit into from Mar 21, 2024

Conversation

evyncke
Copy link
Contributor

@evyncke evyncke commented Mar 17, 2024

Fixing #7096 by using the Bootstrap 'info' rather than 'secondary' color for Add to calendar.

Copy link

codecov bot commented Mar 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.94%. Comparing base (187c2c5) to head (013a75a).
Report is 73 commits behind head on main.

❗ Current head 013a75a differs from pull request most recent head ccc11db. Consider uploading reports for the commit ccc11db to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7210      +/-   ##
==========================================
- Coverage   88.98%   88.94%   -0.05%     
==========================================
  Files         291      291              
  Lines       40717    41067     +350     
==========================================
+ Hits        36233    36525     +292     
- Misses       4484     4542      +58     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@evyncke
Copy link
Contributor Author

evyncke commented Mar 18, 2024

I am lost now about what I did wrong wrt whitespaces (sorry Nick).

Anyway, it is very simple to redo the change: change #6C757D into #54B4D3 in two locations in the file.

@NGPixel
Copy link
Member

NGPixel commented Mar 21, 2024

I've reset your PR to the latest main commit (to fix the whitespace issues) and made similar color changes to the buttons.

I also fixed the timezone buttons text color in dark mode being hard to read.

image
image

@evyncke
Copy link
Contributor Author

evyncke commented Mar 21, 2024

Thanks Nick

@rjsparks rjsparks merged commit 7f2c3ed into ietf-tools:main Mar 21, 2024
6 of 7 checks passed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants