fix: redundant word in banner for Legacy stream documents#7207
Conversation
fix: Change "Legacy stream" to "Legacy" chore: Add "stream" to stream.desc as needed Fixes: ietf-tools#6902
The stream_desc key isn't used in template/doc/docuemnt_draft.html to don't pass it in nor compute it Fixes: ietf-tools#6902
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7207 +/- ##
==========================================
- Coverage 88.98% 88.94% -0.05%
==========================================
Files 291 291
Lines 40717 41059 +342
==========================================
+ Hits 36233 36518 +285
- Misses 4484 4541 +57 ☔ View full report in Codecov by Sentry. |
| @@ -14042,7 +14042,7 @@ | |||
| }, | |||
| { | |||
| "fields": { | |||
| "desc": "Legacy stream", | |||
| "desc": "Legacy", | |||
There was a problem hiding this comment.
This won't actually change production. it will show up here as a side-effect of the change in the database instead. The PR will need a data migration to change the name.
There was a problem hiding this comment.
Got it. It will take me a few days to re-understand the migration stuff. If you want to add a commit or hints to me, feel free. (Not asking, just not wanting to be a blocker if I don't have to be)
There was a problem hiding this comment.
No worries, this can wait awhile
NGPixel
changed the title
This does all the changes suggested by @rjsparks in #6902 and a little bit more cleanup