fix: Use email or name when building community list view#7203
+2
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
instead of email
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7203 +/- ##
==========================================
- Coverage 88.98% 88.93% -0.05%
==========================================
Files 291 291
Lines 40717 41063 +346
==========================================
+ Hits 36233 36521 +288
- Misses 4484 4542 +58 ☔ View full report in Codecov by Sentry. |
|
Since this is fixing a crash bug, we should add, or modify an existing test to include, a test that exercises the condition that led to the crash. That test should also cover the view for person Y after having constructed a person X with name N and email E, and a person Y with name N (note same name) but no email. |
rjsparks
requested changes
Mar 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7036
An additional argument has been added to pass the
email_or_namevariable through.