Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Revert "Email authors" link for an RFC to the draft that it came from#7077

Merged
merged 3 commits into from Feb 28, 2024

Conversation

pselkirk
Copy link
Collaborator

Fixes #6856

Copy link
Member

@rjsparks rjsparks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The tests aren't looking at the link generated for the button. Maybe they should - if we left the changes to document_draft.html in place, the button would have generated a bad URL I think.

Comment on lines 614 to 616
href="mailto:{{ doc_name }}@ietf.org?subject=Mail%20regarding%20{{ doc.name }}">
<i class="bi bi-envelope">
</i>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be a full revert - there should be no changes to document_draft.html for this PR.

@rjsparks rjsparks merged commit ce1571e into ietf-tools:main Feb 28, 2024
7 checks passed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Email authors" button provides invalid email for https://datatracker.ietf.org/doc/html/rfc4035
2 participants