Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Group admin form accepts acronyms starting with numbers for SDO groups#7051

Merged
merged 3 commits into from Feb 20, 2024
Merged

feat: Group admin form accepts acronyms starting with numbers for SDO groups #7051

merged 3 commits into from Feb 20, 2024

Conversation

pselkirk
Copy link
Collaborator

Fixes #6825

@codecov Codecov
Copy link

codecov bot commented Feb 12, 2024 •
edited

Codecov Report

Attention: 11 lines in your changes are missing coverage. Please review.

Comparison is base (d31605e) 88.91% compared to head (ae7ddf6) 88.97%.
Report is 38 commits behind head on main.

❗ Current head ae7ddf6 differs from pull request most recent head 5d4c09c. Consider uploading reports for the commit 5d4c09c to get more accurate results

Files Patch % Lines
ietf/sync/views.py 8.33% 11 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7051      +/-   ##
==========================================
+ Coverage   88.91%   88.97%   +0.05%     
==========================================
  Files         289      291       +2     
  Lines       40454    40717     +263     
==========================================
+ Hits        35971    36226     +255     
- Misses       4483     4491       +8

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

rjsparks
rjsparks requested changes Feb 12, 2024
View reviewed changes
Copy link
Member

@rjsparks rjsparks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to tune/test the sdo acronym validation a bit more.

ietf/group/admin.py Outdated Show resolved Hide resolved
rjsparks
rjsparks requested changes Feb 12, 2024
View reviewed changes
Copy link
Member

@rjsparks rjsparks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add the fail tests for group type wg for leading or trailing hyphens

ietf/group/tests_info.py Show resolved Hide resolved
@rjsparks rjsparks merged commit 65cf001 into ietf-tools:main Feb 20, 2024
7 checks passed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rjsparks rjsparks rjsparks approved these changes
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

group admin form should allow acronyms that start with numbers other sdo groups.
2 participants
@pselkirk @rjsparks