fix: Raise 404 when multiple person found in /community/personal/#7038
Conversation
kesara
force-pushed
the
fix/multiplepersonerror
branch
2 times, most recently
from
4cba512
to
051022d
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #7038 +/- ##
=======================================
Coverage 88.97% 88.98%
=======================================
Files 291 291
Lines 40717 40717
=======================================
+ Hits 36229 36233 +4
+ Misses 4488 4484 -4 ☔ View full report in Codecov by Sentry. |
ietf/community/views.py
Outdated
| @@ -54,7 +54,7 @@ def view_list(request, email_or_name=None): | |||
| try: | |||
| clist = lookup_community_list(request, email_or_name) | |||
| except MultiplePersonError as err: | |||
| return HttpResponse(str(err), status=300) | |||
| raise Http404(str(err)) | |||
There was a problem hiding this comment.
We should either 404 with no decoration or use some other response. I'm not quickly coming up with a use-case for telling someone that the string entered matches multiple people is helpful.
There was a problem hiding this comment.
Yeah! 404 page doesn't show any decorations. I'll remove error strings.
kesara
force-pushed
the
fix/multiplepersonerror
branch
from
051022d
to
ebc0f61
Compare
Yes, I think this would make sense, and it would obviate the need for the MultiplePerssonError exception in the first place - the utility could simply raise the 404 instead. |
No description provided.