Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: celery tasks to replace ietf/bin scripts#6971

Merged

Conversation

jennifer-richards
Copy link
Member

This adds celery tasks that implement most of the scripts called by bin/hourly, bin/daily, etc.

It still remains to do the same for management commands (in addition to tackling Night-runner and Cron-runner, of course).

Cutting this off here to get feedback on something approaching a reasonable chunk - though probably already a bit big for that purpose.

My linter does not like variables defined outside
of __init__()
Calls idindex generation functions and does the file
update dance to put them in place.
More testable this way
Not sure this is the right thing to do, but it's the
same as rfc_editor_index_update_task
This matches the crontab file field order
Copy link

codecov bot commented Jan 26, 2024

Codecov Report

Attention: 11 lines in your changes are missing coverage. Please review.

Comparison is base (c64b1da) 88.92% compared to head (9fa518d) 88.94%.
Report is 10 commits behind head on main.

Files Patch % Lines
ietf/sync/views.py 8.33% 11 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6971      +/-   ##
==========================================
+ Coverage   88.92%   88.94%   +0.02%     
==========================================
  Files         289      291       +2     
  Lines       40454    40577     +123     
==========================================
+ Hits        35972    36091     +119     
- Misses       4482     4486       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rjsparks rjsparks merged commit b4cf04a into ietf-tools:main Jan 31, 2024
9 checks passed
@jennifer-richards jennifer-richards deleted the moar-celery-cronch-cronch-cronch branch January 31, 2024 23:05
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants