New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Bump version to 12 in a couple places#6789
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6789 +/- ##
==========================================
- Coverage 88.81% 88.80% -0.02%
==========================================
Files 285 285
Lines 40291 40383 +92
==========================================
+ Hits 35785 35862 +77
- Misses 4506 4521 +15 ☔ View full report in Codecov by Sentry. |
Let's talk about what to do with these things rather than just have an epoch token in them. @NGPixel Does any software made decisions based on the content of these settings? We show them in some templates and it would be nicer to show something more useful to the viewer. |
They are used in the dev builds. Production builds are using the version generated from the conventional commits. No "decision" is made based on them though. |
It's perhaps possible to extract the version from the tag using something like
(the output format is Could do this at run-time if the |
The commit just now uses git inside a dev container to extract the most recent release tag, then adds the branch name and commit hash in the same format as shows up on dev releases. E.g., on my system it looks like This should only affect work in dev containers, and I think will work under VS Code but I have not tried. Happy to adjust the format (maybe something that more clearly labels it as a non-release version number?) or add better error checking, but wanted to get feedback on the general approach first. |
Just realized I'm being silly about the branch / commit, cleanup incoming... |
I think we missed these spots in the v12.0.0 release. I don't think we need to mark these as breaking, but note that the equivalent changes were part of a breaking change when v11.0.0 came out.