Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Bump version to 12 in a couple places#6789

Merged
merged 4 commits into from Mar 11, 2024

Conversation

jennifer-richards
Copy link
Member

I think we missed these spots in the v12.0.0 release. I don't think we need to mark these as breaking, but note that the equivalent changes were part of a breaking change when v11.0.0 came out.

Copy link

codecov bot commented Dec 16, 2023

Codecov Report

Attention: Patch coverage is 0% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 88.80%. Comparing base (501a5b8) to head (cfea732).
Report is 145 commits behind head on main.

❗ Current head cfea732 differs from pull request most recent head 84c95e8. Consider uploading reports for the commit 84c95e8 to get more accurate results

Files Patch % Lines
ietf/__init__.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6789      +/-   ##
==========================================
- Coverage   88.81%   88.80%   -0.02%     
==========================================
  Files         285      285              
  Lines       40291    40383      +92     
==========================================
+ Hits        35785    35862      +77     
- Misses       4506     4521      +15     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rjsparks
Copy link
Member

Let's talk about what to do with these things rather than just have an epoch token in them.

@NGPixel Does any software made decisions based on the content of these settings?

We show them in some templates and it would be nicer to show something more useful to the viewer.

@NGPixel
Copy link
Member

NGPixel commented Dec 18, 2023

They are used in the dev builds. Production builds are using the version generated from the conventional commits.

No "decision" is made based on them though.

@jennifer-richards
Copy link
Member Author

jennifer-richards commented Dec 19, 2023

It's perhaps possible to extract the version from the tag using something like

dev ➜ /workspace $ git describe --tags $(git rev-parse head)
12.0.0-13-g7d447802d

dev ➜ /workspace $ git checkout 6083205cc8068234bc9a92b3ff66a8a5f36a9d74

dev ➜ /workspace $ git describe --tags $(git rev-parse head)
11.16.0-281-g6083205cc

(the output format is <most recent tag>-<commit count since tag>-g<abbreviated SHA>)

Could do this at run-time if the __version__ is empty (or some placeholder value) so that local dev will say something sensible in the page footer. For sandbox deploys it could be done as part of the deploy action (if there's not a better way to grab the info)

NGPixel
NGPixel previously approved these changes Feb 23, 2024
@jennifer-richards
Copy link
Member Author

The commit just now uses git inside a dev container to extract the most recent release tag, then adds the branch name and commit hash in the same format as shows up on dev releases. E.g., on my system it looks like Version 12.0.0-dev (v12-bump - cfea732). (It's "12.0.0-dev" because this PR is outdated - if I switch to current main, I get Version 12.6.1-dev (... instead.)

This should only affect work in dev containers, and I think will work under VS Code but I have not tried. Happy to adjust the format (maybe something that more clearly labels it as a non-release version number?) or add better error checking, but wanted to get feedback on the general approach first.

@jennifer-richards
Copy link
Member Author

Just realized I'm being silly about the branch / commit, cleanup incoming...

@rjsparks rjsparks merged commit 3b67d9e into ietf-tools:main Mar 11, 2024
7 checks passed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants