Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Prevent test suite artifact creation in work directory#6438

Open
wants to merge 16 commits into
base: main
Choose a base branch
from

Conversation

larseggert
Copy link
Collaborator

@larseggert larseggert commented Oct 5, 2023

Also remove a few other stale test assets while I'm here.

Fixes #4020
Fixes #3520

Also remove a few other stale test assets while I'm here.
@codecov
Copy link

codecov bot commented Oct 5, 2023

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (288b69d) 88.78% compared to head (5ae532c) 88.78%.
Report is 1 commits behind head on main.

Files Patch % Lines
ietf/doc/models.py 0.00% 3 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6438   +/-   ##
=======================================
  Coverage   88.78%   88.78%           
=======================================
  Files         285      285           
  Lines       40377    40378    +1     
=======================================
+ Hits        35850    35851    +1     
  Misses       4527     4527           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

dev/tests/settings_local.py Outdated Show resolved Hide resolved
dev/tests/settings_local.py Show resolved Hide resolved
@larseggert
Copy link
Collaborator Author

@rjsparks

CRITICALS:
?: (datatracker.E0006) A directory used by the I-D submission tool does not
exist at the path given in the settings file. The setting is:
IDSUBMIT_REPOSITORY_PATH = /assets/ietfdata/doc/draft/repository

@larseggert
Copy link
Collaborator Author

There are a ton of directories that are being created in docker/scripts/app-create-dirs.sh - it's unclear to me how many of them are actually needed to run a dev instance and the CI.

@larseggert
Copy link
Collaborator Author

@rjsparks I think I made all the changes you requested?

@rjsparks
Copy link
Member

rjsparks commented Dec 8, 2023

Yes, I'm holding this for more work post the feat/rfc merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make test suite generate files outside of the source tree temporary directories not cleaned up after tests
2 participants