chore: Add absent iesg 0001_initial.py migration#5336
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #5336 +/- ##
=======================================
Coverage 88.74% 88.74%
=======================================
Files 286 286
Lines 39669 39669
=======================================
+ Hits 35205 35206 +1
+ Misses 4464 4463 -1 see 3 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
rjsparks
approved these changes
Mar 16, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This began as just the first commit, cherry-picked from #5294. This added the
0001_initial.pymigration to theiesgapp that needs to be run with--fakebecause it creates tables that already exist.Comparing the migration to the database, it seems that an index was meant to be added to
TelechatDateon itsdatefield. That came in on 088033d where a number of indexes were added. It looks like it went unnoticed at the time that Django skipped overiesgwhen creating migrations. I've added the index-that-should-have-been, though we could instead remove it from the model.We need to merge and deploy this separately from other work touching the iesg migrations because it otherwise will prevent CI tests from running on the PRs. (I am thinking of #5294 here, of course.)