Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

llc-comms group doesn't appear in menus#7318

Open
1 task done
ghwood opened this issue Apr 12, 2024 · 5 comments
Open
1 task done

llc-comms group doesn't appear in menus #7318

ghwood opened this issue Apr 12, 2024 · 5 comments
Labels
bug Something isn't working

Comments

@ghwood
Copy link

ghwood commented Apr 12, 2024

Describe the issue

I expect the llc-comms group to appear in the Groups->IETF LLC menu but it doesn't.
image

(I don't see it anywhere else in the menu structure either.)

Perhaps related: The usual pattern for LLC groups (e.g. https://datatracker.ietf.org/adm/llc-board/about/) also doesn't seem to work.

Code of Conduct
@ghwood ghwood added the bug Something isn't working label Apr 12, 2024
@rjsparks
Copy link
Member

https://datatracker.ietf.org/adm/llc-board/about/ works fine for me?
But I think you meant https://datatracker.ietf.org/adm/llc-comms/about/
It is a group of type team just like the tools-team so you can get the meetecho behavior you were looking for.
Moving it to be some other kind of group and retaining those behaviors will require changing how all the other groups of that type behave.

Also, please try to forget that /{grouptypeacronym}/{groupacronym} exists. It will stop working in the future as soon as I find a better way to provide a URL to discuss all the groups of type grouptype. Use /group/{groupacronym} instead. Always. All the previous variants are, or will soon be, redirecting to that URL pattern.

@ghwood
Copy link
Author

ghwood commented Apr 16, 2024

Yes, I meant ~/adm/llc-board/about as an example that works whereas ~/adm/llc-comms/about does not, and now I understand why it doesn't and won't in the future.

But the main point is that I would expect llc-comms to appear in the menu Groups->IETF LLC->, but it doesn't. Are my expectations wrong here as well?

@rjsparks
Copy link
Member

the groups menu is built based on the group type. the llc-comms group currently is built under "active teams".

@rjsparks
Copy link
Member

To reiterate, and be a bit more explicit - llc-comms is currently at team because it behaves like a team. All groups of a given type behave the same way - it's controlled with a GroupFeature instance for the group's type:

datatracker/ietf/group/models.py

Lines 238 to 282 in 280481b

class GroupFeatures(models.Model):
type = OneToOneField(GroupTypeName, primary_key=True, null=False, related_name='features')
#history = HistoricalRecords()
#
need_parent = models.BooleanField("Need Parent", default=False, help_text="Does this group type require a parent group?")
parent_types = models.ManyToManyField(GroupTypeName, blank=True, related_name='child_features',
help_text="Group types allowed as parent of this group type")
default_parent = models.CharField("Default Parent", max_length=40, blank=True, default="",
help_text="Default parent group acronym for this group type")
#
has_milestones = models.BooleanField("Milestones", default=False)
has_chartering_process = models.BooleanField("Chartering", default=False)
has_documents = models.BooleanField("Documents", default=False) # i.e. drafts/RFCs
has_session_materials = models.BooleanField("Sess Matrl.", default=False)
has_nonsession_materials= models.BooleanField("Other Matrl.", default=False)
has_meetings = models.BooleanField("Meetings", default=False)
has_reviews = models.BooleanField("Reviews", default=False)
has_default_chat = models.BooleanField("Chat", default=False)
#
acts_like_wg = models.BooleanField("WG-Like", default=False)
create_wiki = models.BooleanField("Wiki", default=False)
custom_group_roles = models.BooleanField("Cust. Roles",default=False)
customize_workflow = models.BooleanField("Workflow", default=False)
is_schedulable = models.BooleanField("Schedulable",default=False)
show_on_agenda = models.BooleanField("On Agenda", default=False)
agenda_filter_type = models.ForeignKey(AgendaFilterTypeName, default='none', on_delete=PROTECT)
req_subm_approval = models.BooleanField("Subm. Approval", default=False)
#
agenda_type = models.ForeignKey(AgendaTypeName, null=True, default="ietf", on_delete=CASCADE)
about_page = models.CharField(max_length=64, blank=False, default="ietf.group.views.group_about" )
default_tab = models.CharField(max_length=64, blank=False, default="ietf.group.views.group_about" )
material_types = IETFJSONField(max_length=64, accepted_empty_values=[[], {}], blank=False, default=["slides"])
default_used_roles = IETFJSONField(max_length=256, accepted_empty_values=[[], {}], blank=False, default=[])
admin_roles = IETFJSONField(max_length=64, accepted_empty_values=[[], {}], blank=False, default=["chair"]) # Trac Admin
docman_roles = IETFJSONField(max_length=128, accepted_empty_values=[[], {}], blank=False, default=["ad","chair","delegate","secr"])
groupman_roles = IETFJSONField(max_length=128, accepted_empty_values=[[], {}], blank=False, default=["ad","chair",])
groupman_authroles = IETFJSONField(max_length=128, accepted_empty_values=[[], {}], blank=False, default=["Secretariat",])
matman_roles = IETFJSONField(max_length=128, accepted_empty_values=[[], {}], blank=False, default=["ad","chair","delegate","secr"])
role_order = IETFJSONField(max_length=128, accepted_empty_values=[[], {}], blank=False, default=["chair","secr","member"],
help_text="The order in which roles are shown, for instance on photo pages. Enter valid JSON.")
session_purposes = IETFJSONField(max_length=256, accepted_empty_values=[[], {}], blank=False, default=[],
help_text="Allowed session purposes for this group type",
validators=[JSONForeignKeyListValidator(SessionPurposeName)])

@ghwood
Copy link
Author

ghwood commented Apr 16, 2024

Thank you for taking the time to provide the detail. I now understand the situation. Given the current model, I don't have a good suggestion about how to reconcile the desired group behavior with expected menu structure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests

2 participants
@ghwood @rjsparks