Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Youtube link is not shown in Notes and Recordings section of past meeting materials#6543

Open
rjsparks opened this issue Oct 25, 2023 · 5 comments · May be fixed by #7197
Open

Youtube link is not shown in Notes and Recordings section of past meeting materials #6543

rjsparks opened this issue Oct 25, 2023 · 5 comments · May be fixed by #7197
Labels
accepted component: meeting/ contrib-easy Easy dev difficulty for contribution enhancement New feature or request

Comments

@rjsparks
Copy link
Member

See https://datatracker.ietf.org/meeting/interim-2023-tools-11/session/tools

There is an icon in the top right that links to the youtube recording.

There should also be a row for it in the Notes and Recordings section of that view.
@rjsparks rjsparks added enhancement New feature or request accepted contrib-easy Easy dev difficulty for contribution component: meeting/ labels Nov 2, 2023
@richsalz
Copy link
Collaborator

I think this line is wrong:

{% if meeting.number|add:"0" >= 80 %}

When I change it to {% if 1 %} I see the desired links.

@rjsparks
Copy link
Member Author

{% if 1 %} is always True. - it would show links that would not work for, e.g., IETF79.

btw - a permalink into the repo would be better than a cut-paste of a single line.

@richsalz
Copy link
Collaborator

Thanks for the tip, will try to remember to do that. My point was that the current if test seems to be always failing. And it turns out because it thinks the meeting from your example is interim-2023-tools-11

richsalz added a commit to richsalz/datatracker that referenced this issue Mar 16, 2024
@richsalz
fix: Show recordings for interims
becd236 
List the recordings if the "meeting numnber" starts with "interim"

Fixes: ietf-tools#6543
@rjsparks
Copy link
Member Author

that's awesome.

Yes, the conditional will have to become aware of meeting type.

@rjsparks rjsparks reopened this Mar 16, 2024
@richsalz richsalz linked a pull request Mar 16, 2024 that will close this issue
Open
@rjsparks
Copy link
Member Author

(sorry - manage to get the wrong button)

richsalz added a commit to richsalz/datatracker that referenced this issue Mar 16, 2024
@richsalz
fix: Update test in session buttons
f414ae4 
Put same "records available?" test in the buttons that we did
in the interim meeting status page.

Fixes: ietf-tools#6543
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
accepted component: meeting/ contrib-easy Easy dev difficulty for contribution enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Show recordings for interims richsalz/datatracker
2 participants
@richsalz @rjsparks