Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rework the search button in the action button row for a document page to not link to external search engines#7009

Closed
rjsparks opened this issue Feb 1, 2024 · 2 comments · Fixed by #7093
Closed

Rework the search button in the action button row for a document page to not link to external search engines #7009

rjsparks opened this issue Feb 1, 2024 · 2 comments · Fixed by #7093
Assignees
@pselkirk
Labels
accepted component: doc/ medium

Comments

@rjsparks
Copy link
Member

rjsparks commented Feb 1, 2024

Change
image
to a simple button that searches the mailarchive only.
This was referenced Feb 1, 2024
Closed
Closed
@rjsparks
Copy link
Member Author

rjsparks commented Feb 1, 2024

In the process, I believe this will become dead code:

datatracker/ietf/doc/views_doc.py

Line 480 in 4c7be64

search_archive = "www.ietf.org/mail-archive/web/"

If I'm correct, please clean it away.

@rjsparks rjsparks mentioned this issue Feb 1, 2024
Closed
@Sarrac3873

This comment was marked as spam.

Sign in to view
@pselkirk pselkirk mentioned this issue Feb 22, 2024
Merged
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@pselkirk pselkirk

Labels
accepted component: doc/ medium
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor: Remove Google from document history search pselkirk/datatracker
3 participants
@pselkirk @rjsparks @Sarrac3873