Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move "apply patches" check to its own management command#4820

Closed
1 task done
jennifer-richards opened this issue Dec 2, 2022 · 1 comment
Closed
1 task done

Move "apply patches" check to its own management command #4820

jennifer-richards opened this issue Dec 2, 2022 · 1 comment
Labels
accepted enhancement New feature or request major

Comments

@jennifer-richards
Copy link
Member

Description

One of the checks in checks.py, run by ietf/manage.py check, applies patches from the patch/ path to the Python libraries. In some cases, such as in the celery beat Docker container, we need to be sure these patches have been applied but do not need to run any of the other checks. Would be nice to break the patching out to a separate management command.

The check command could continue to apply the patches, but should at least fail if the patches haven't been applied.

Code of Conduct
@jennifer-richards jennifer-richards added the enhancement New feature or request label Dec 2, 2022
@jennifer-richards jennifer-richards mentioned this issue Apr 25, 2024
Merged
@jennifer-richards
Copy link
Member Author

Closing before this hits main since presumably feat/helm will eventually get merged there.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
accepted enhancement New feature or request major
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests

2 participants
@rjsparks @jennifer-richards