Skip to content

Commit 5fc0f69

Browse files
feat: Show room functional name when editing timeslots (#7075)
* feat: Show functional name in str(Room) * feat: Show func name in edit_timeslots.html * test: Update test_location_options
1 parent 52a7076 commit 5fc0f69

File tree

3 files changed

+6
-4
lines changed

3 files changed

+6
-4
lines changed

ietf/meeting/models.py

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -451,8 +451,9 @@ class Room(models.Model):
451451
# end floorplan-related stuff
452452

453453
def __str__(self):
454-
return u"%s size: %s" % (self.name, self.capacity)
455-
454+
if len(self.functional_name) > 0 and self.functional_name != self.name:
455+
return f"{self.name} [{self.functional_name}] (size: {self.capacity})"
456+
return f"{self.name} (size: {self.capacity})"
456457

457458
def dom_id(self):
458459
return "room%u" % (self.pk)

ietf/meeting/tests_schedule_forms.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -140,13 +140,13 @@ def test_location_options(self):
140140
rendered = str(TimeSlotEditForm(instance=ts)['location'])
141141
# noinspection PyTypeChecker
142142
self.assertInHTML(
143-
f'<option value="{ts.location.pk}" selected>{ts.location.name} size: None</option>',
143+
f'<option value="{ts.location.pk}" selected>{ts.location}</option>',
144144
rendered,
145145
)
146146
for room in rooms:
147147
# noinspection PyTypeChecker
148148
self.assertInHTML(
149-
f'<option value="{room.pk}">{room.name} size: {room.capacity}</option>',
149+
f'<option value="{room.pk}">{room}</option>',
150150
rendered,
151151
)
152152

ietf/templates/meeting/timeslot_edit.html

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -121,6 +121,7 @@ <h1>
121121
<tr>
122122
<th scope="row">
123123
<span class="room-heading">{{ room.name }}
124+
{% if room.functional_name and room.name != room.functional_name %} - {{ room.functional_name }}{% endif %}
124125
{% if room.capacity %}<span class="capacity">({{ room.capacity }})</span>{% endif %}
125126
</span>
126127
</th>

0 commit comments

Comments
 (0)