Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v1.5.6 breaks 32-bit Windows clang-cl build#4010

Open
terrelln opened this issue Apr 1, 2024 · 3 comments
Open

v1.5.6 breaks 32-bit Windows clang-cl build #4010

terrelln opened this issue Apr 1, 2024 · 3 comments

Comments

@terrelln
Copy link
Contributor

terrelln commented Apr 1, 2024 •
edited

See 94c1020

Reported-by: @georgthegreat
@terrelln terrelln mentioned this issue Apr 1, 2024
Merged
@terrelln
Copy link
Contributor Author

terrelln commented Apr 1, 2024

#3998 works around the issue for clang >= 16, but we still need a fix for older clang versions.

Honestly, we could just drop support for CpuId for older clang versions on Windows, and just return that nothing is supported.

@georgthegreat
Copy link
Contributor

I am OK with dropping older clangs support.

I do not know what chrome and firefox are using, however.

@terrelln
Copy link
Contributor Author

terrelln commented Apr 1, 2024

I am OK with dropping older clangs support.

To be clear, everything would still work, just older compilers wouldn't get opted into code gated by checking the CPUID. So only perf would be impacted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests

2 participants
@georgthegreat @terrelln