Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Raise version's in win32 binaries header#4003

Open
basid-irk opened this issue Mar 30, 2024 · 3 comments
Open

Raise version's in win32 binaries header #4003

basid-irk opened this issue Mar 30, 2024 · 3 comments

Comments

@basid-irk
Copy link

Related to #932
Currendly zstd.exe build and link as:

Timestamp: 05.04.2023 06:24:47
Machine: x86
Linker version: 2.40
Operating system version: 4.0
Subsystem version: 4.0
Windows console
Windows 32-bit executable.

De-facto zstd.exe not started on (yes, unsupported) Windows Server 2003 R2 SP2 (32-bit): no entry poind InitializeConditionVariable in kernel32.dll (5.2.3790.5295 (srv03_sp2_qfe.140205-1447), 2014-02-06)
Will honest raise verion of subsystem/operation system up to 6.0?

P.S.

Timestamp: 15.08.2022 23:18:14
Machine: x86
Linker version: 2.25
Operating system version: 4.0
Subsystem version: 4.0
Windows console
Windows 32-bit executable.
File version: 1.9.4.0
Internal name: lz4
Original filename: lz4..exe
Product name: LZ4
Product version: 1.9.4.0

still work on that OS (lz4 -b1 -e9 run fine).
@terrelln
Copy link
Contributor

Will honest raise verion of subsystem/operation system up to 6.0?

I'm not quite sure I understand. Are you saying that zstd.exe is advertising it works with older Windows versions, when it does not? And that we should raise the version that zstd.exe advertises that it supports?

I guess this would involve a change in build scripts, but if you have any advice about how to achieve this, please let us know.

@basid-irk
Copy link
Author

For MSVC linker - link /subsystem or build properties.

@stati64
Copy link

stati64 commented Apr 1, 2024

We work around this with LoadLibraryW() and GetProcAddress() and
then avoiding or emulating absent features.

#define _WIN32_WINNT _WIN32_WINNT_WIN2K
before including windows.h will enumerate all the missing features.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests

3 participants
@terrelln @stati64 @basid-irk