Add HttpProtocol enum and http_protocol field to Message#21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds a new `HttpProtocol` enum that represents HTTP versions and adds an optional `http_protocol` field to the `Message` message. This allows specifying the particular HTTP version used if the DOH protocol is in use. Hypothetically, this field could be used in the future to specify the HTTP version in use for an HTTP-based DNS transport protocol that is not the currently existing RFC 8484 DOH protocol. However, at the time of this writing none of the other currently defined dnstap `SocketProtocol` values are HTTP-based transports, so the `http_protocol` field should only be set if `socket_protocol` is set to DOH. Otherwise, the `http_protocol` field should be left unset.
|
This addresses #20. |
rgacogne
approved these changes
Mar 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds a new
HttpProtocolenum that represents HTTP versions and adds an optionalhttp_protocolfield to theMessagemessage. This allows specifying the particular HTTP version used if the DOH protocol is in use.Hypothetically, this field could be used in the future to specify the HTTP version in use for an HTTP-based DNS transport protocol that is not the currently existing RFC 8484 DOH protocol. However, at the time of this writing none of the other currently defined dnstap
SocketProtocolvalues are HTTP-based transports, so thehttp_protocolfield should only be set ifsocket_protocolis set to DOH. Otherwise, thehttp_protocolfield should be left unset.