Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rec: Generate EDE in more cases, specifically on unreachable auths or sythesized results.#12334

Merged
merged 5 commits into from Jan 3, 2023

Commits on Dec 16, 2022

  1. Generate EDE in more cases, specifically on unreachable auths or synt…

    …hesized results.
    
    As there is no specific EDE for synthesised, use noError with a text.
    
    We have to be careful here: a single client query can lead to
    multiple beginResolve calls. Some of these are done after the main
    result has been looked up, for example to validate the result. These
    subsequent calls can generate EDE's but we do not want to copy the
    EDE to the main result in those cases. A typical example would be
    an absent DS for an Insecure domain. Nothing wrong with these but
    we do not want the potential absent DS EDE (which could be synthesize)
    to be returned with the main query,
    
    To solve this, mimic the processing of validation state and add
    an extra argument to a few methods.
    
    I am not terribly happy with the extra argument. Maybe we should
    move to an object holding the parameters and result status of the
    nested or subsequent calls.  This would also avoid some of the saveX,
    setX, beginResolve, restore X sequences.
    
    So marking this as Draft for now.
    omoerbeek committed Dec 16, 2022
    Configuration menu
    Copy the full SHA
    3e5667f View commit details
    Browse the repository at this point in the history
  2. Reformat

    omoerbeek committed Dec 16, 2022
    Configuration menu
    Copy the full SHA
    5eb762a View commit details
    Browse the repository at this point in the history

Commits on Dec 20, 2022

  1. Introduce a context object holding vState and extendedErrors

    Later, more fields that apply to a specific beginResolve call
    might be added.
    omoerbeek committed Dec 20, 2022
    Configuration menu
    Copy the full SHA
    718c531 View commit details
    Browse the repository at this point in the history
  2. A few tests on the new EDEs

    omoerbeek committed Dec 20, 2022
    Configuration menu
    Copy the full SHA
    811bddf View commit details
    Browse the repository at this point in the history

Commits on Jan 3, 2023

  1. Configuration menu
    Copy the full SHA
    79cc1d6 View commit details
    Browse the repository at this point in the history