Fix GNU HURD sched_setaffinity compile (GH #82)#83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
noloader
changed the title
wcawijngaards
approved these changes
Mar 20, 2020
wcawijngaards
added a commit
that referenced
this pull request
Mar 20, 2020
And fixup the review comment.
|
Thanks! I merged and fixed the review comment. I don't think we have previous test for GNU Herd, but it is nice to have support. |
Yeah, I'm a big fan of "it just works". Users expect to clone/upack, then |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes GNU HURD compiles due to
sched_setaffinity.GNU HURD was failing compiles due to detection of
sched_setaffinity. HURD needs_GNU_SOURCEdefined, and then needs<sched.h>included for the proper definition ofcpuset_t. As such, it needed a customAC_COMPILE_IFELSEtest.We cannot perform
AC_LINK_IFELSE. See the Issue 82 report for the link warning that could cause mis-detection ofsched_setaffinity.There was a lot of trailing whitespace in the files, so
configure.acalso gotsed -i -e's/[[:space:]]*$//' configure.acto trim it.Also see Issue 82, util.c:1190: warning: sched_setaffinity is not implemented and will always fail.