tsig: Fix compilation without HAVE_SSL#32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CRYPTO_memcmp is an OpenSSL function that is used outside of the HAVE_SSL path. This fixes compilation when HAVE_SSL is false.
|
Thanks for the patch. Implemented a fallback routine, because without the fixedtime compare there is a vulnerability. But no SSL for the hash, anyway. Also fixed compilation for two other cases where compilation without SSL failed, with ratelimits and the newer DNSoverTLS code. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CRYPTO_memcmp is an OpenSSL function that is used outside of the HAVE_SSL path.
This fixes compilation when HAVE_SSL is false.