Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Official Docker Image#285

Open
nbish11 opened this issue Jun 26, 2023 · 2 comments
Open

Official Docker Image #285

nbish11 opened this issue Jun 26, 2023 · 2 comments

Comments

@nbish11
Copy link

nbish11 commented Jun 26, 2023

What are your thoughts on adding docker support? Both Unbound and NSD would be great to have as officially maintained docker images and some of your other projects already have docker support. I have an example repository over at docker-nsd. I am more than happy to create a pull request and help to continue to maintain the image. (I would prefer to contribute here rather than have a separate fork.)
@k0ekk0ek
Copy link
Contributor

Hi @nbish11! Thank you for bringing this to our attention. We'd love to add a reference in contrib for this, but prefer not to ship an official Docker image at this point. The reason for that is that there are too many configuration parameters and there's no one recommended way that is guaranteed to work for every user. Adding it to contrib is a good solution in situations like this. Issuing a PR against contrib/Docker (or similar) is probably the best way forward? Just adding a link to contrib/README.md is another possibility.

@nbish11
Copy link
Author

nbish11 commented Jun 27, 2023

Thanks k0ekk0ek. I will open a PR against contrib a little later to close this issue.

Your not wrong about the config options. I've actually 'borrowed' your docker magic build technique from the krill library to allow NSD to be built for cpu or memory optimisation; as even for me, NSD needs to be built differently, depending on the project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests

2 participants
@k0ekk0ek @nbish11