Last Call Review of draft-ietf-cose-typ-header-parameter-02
review-ietf-cose-typ-header-parameter-02-opsdir-lc-hares-2024-02-18-00
Request | Review of | draft-ietf-cose-typ-header-parameter |
---|---|---|
Requested revision | No specific revision (document currently at 05) | |
Type | Last Call Review | |
Team | Ops Directorate (opsdir) | |
Deadline | 2024-02-26 | |
Requested | 2024-02-12 | |
Authors | Michael B. Jones , Orie Steele | |
I-D last updated | 2024-02-18 | |
Completed reviews |
Opsdir Last Call review of -02
by Susan Hares
(diff)
Secdir Last Call review of -03 by Dan Harkins (diff) Genart Last Call review of -02 by Dale R. Worley (diff) |
|
Assignment | Reviewer | Susan Hares |
State | Completed | |
Request | Last Call review on draft-ietf-cose-typ-header-parameter by Ops Directorate Assigned | |
Posted at | https://mailarchive.ietf.org/arch/msg/ops-dir/G_sWFU8WXi7jir3MuwZcgHJckh0 | |
Reviewed revision | 02 (document currently at 05) | |
Result | Has nits | |
Completed | 2024-02-18 |
review-ietf-cose-typ-header-parameter-02-opsdir-lc-hares-2024-02-18-00
Status: Ready with Nits Nit 1: section 1, paragraph 1, last sentence. When you refer to [RFC8725] for recommending "explicit typing" in section 1, please add the section (3.11) in [RFC8725] that discusses the "explicit typing." It would help the reader of this document easily cross-reference your work. Nit 2: Section 3, paragraph 1, first sentence. Same comment as NIT 1. NIT 3: Section 3, paragraph 1, English sentence grammar Perhaps you want a ":" instead of a ";". If not, perhaps you want to break this sentence into two sentences. Old Text:/ The case for explicit typing of COSE objects is equivalent to the case made for explicit typing in JSON Web Token Best Current Practices [RFC8725]; explicit typing can prevent confusion between different kinds of COSE objects./ Simple fix: / The case for explicit typing of COSE objects is equivalent to the case made for explicit typing in JSON Web Token Best Current Practices [RFC8725]: explicit typing can prevent confusion between different kinds of COSE objects./