Bug 2507 - missing or misleading error messages
Summary: missing or misleading error messages
Status: CLOSED FIXED
Alias: None
Product: Portable OpenSSH
Classification: Unclassified
Component: ssh (show other bugs)
Version: 7.1p1
Hardware: SPARC Solaris
: P5 normal
Assignee: Assigned to nobody
URL:
Keywords:
Depends on:
Blocks: V_7_2
  Show dependency tree / graph
 
Reported: 2015-11-27 02:04 AEDT by Tomas Kuthan
Modified: 2016-08-02 10:40 AEST (History)
2 users (show)

See Also:

Attachments
Call error() on identity_sign() failure, fix typos in ssherr() calls. (1.10 KB, patch)
2015-11-27 02:06 AEDT, Tomas Kuthan 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tomas Kuthan 2015-11-27 02:04:00 AEDT 
After code refactoring for library-like interfaces, error messages are no longer printed for DSA_do_sign() or RSA_sign() failures in some code paths.

When investigating error messaging for signing failures I also noticed, that incorrect messages are printed for sshkey_from_blob() and sshkey_sign() errors in ssh-agent.c.
Comment 1 Tomas Kuthan 2015-11-27 02:06:16 AEDT 
Created attachment 2758 [details]
Call error() on identity_sign() failure, fix typos in ssherr() calls.
Comment 2 flavio.gallucci 2015-11-28 23:42:07 AEDT 
openssh 6x doesn't give this problem.
Comment 3 Damien Miller 2015-12-11 13:20:58 AEDT 
Patch applied - thanks. This will be in the OpenSSH 7.2 release.
Comment 4 Damien Miller 2016-08-02 10:40:49 AEST 
Close all resolved bugs after 7.3p1 release