Bug 2137 - progress meter shows wrong speed during resume
Summary: progress meter shows wrong speed during resume
Status: CLOSED FIXED
Alias: None
Product: Portable OpenSSH
Classification: Unclassified
Component: sftp (show other bugs)
Version: -current
Hardware: All All
: P5 minor
Assignee: Assigned to nobody
URL:
Keywords:
Depends on:
Blocks: V_6_5
  Show dependency tree / graph
 
Reported: 2013-08-01 17:03 AEST by Loganaden Velvindron
Modified: 2015-08-11 23:02 AEST (History)
3 users (show)

See Also:

Attachments
progressmeter diff (543 bytes, text/plain)
2013-08-01 17:03 AEST, Loganaden Velvindron 		no flags Details
Don't assume that the starting poistion is zero (1.24 KB, patch)
2013-09-14 05:04 AEST, Iain Morgan 		dtucker: ok+
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Loganaden Velvindron 2013-08-01 17:03:51 AEST 
Created attachment 2324 [details]
progressmeter diff

Iain Morgan reported that the progress meter would display erroneous speeds when interrupting and resuming downloads.

I'm attaching a WIP fix.
Comment 1 Iain Morgan 2013-09-14 05:04:16 AEST 
Created attachment 2333 [details]
Don't assume that the starting poistion is zero

This looks like it fixes the issue. Save the initial offset when starting the progress meter and use it when cur_pos is zero. Also, use it when reporting the statistics for the completed transfer. This also fixes the negative speed issue when the transfer is interrupted by a signal.
Comment 2 Damien Miller 2013-09-19 10:25:20 AEST 
patch applied; thanks
Comment 3 Damien Miller 2015-08-11 23:02:39 AEST 
Set all RESOLVED bugs to CLOSED with release of OpenSSH 7.1