Bug 1957 - New -K option overwites output file
Summary: New -K option overwites output file
Status: CLOSED FIXED
Alias: None
Product: Portable OpenSSH
Classification: Unclassified
Component: ssh-keygen (show other bugs)
Version: 5.9p1
Hardware: All All
: P2 normal
Assignee: Assigned to nobody
URL:
Keywords:
Depends on:
Blocks: V_6_2
  Show dependency tree / graph
 
Reported: 2011-12-12 01:02 AEDT by Christophe Garault
Modified: 2013-03-22 12:02 AEDT (History)
1 user (show)

See Also:

Attachments
patch for appending instead of rewriting the tested modulus (569 bytes, patch)
2011-12-12 01:02 AEDT, Christophe Garault 		dtucker: ok+
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Christophe Garault 2011-12-12 01:02:33 AEDT 
Created attachment 2118 [details]
patch for appending instead of rewriting the tested modulus

Building moduli file with big prime numbers (8192) takes a lot of time especially in the screening process, so the introduction of the -K option was greatly appreciated.
Unfortunately when interrupted and ran again you loose all the previous tested primes which is almost certainly not the expected behaviour as it takes days to recover them...

Here's a very small patch to prevent that.

Hth.
Christophe Garault
Comment 1 Damien Miller 2012-09-07 11:37:56 AEST 
Retarget uncompleted bugs from 6.1 => 6.2
Comment 2 Damien Miller 2012-09-07 11:40:24 AEST 
Retarget bugs from 6.1 => 6.2
Comment 3 Damien Miller 2013-02-08 11:21:00 AEDT 
Comment on attachment 2118 [details]
patch for appending instead of rewriting the tested modulus

Looks sane to me. Darren touched this code last though :)
Comment 4 Damien Miller 2013-02-11 10:35:46 AEDT 
applied - this will be in openssh-6.2, due soon. Thanks!
Comment 5 Damien Miller 2013-03-22 12:02:02 AEDT 
mark bugs closed by openssh-6.2 release as CLOSED