Created attachment 1824 [details] Use pkg-config to determine linker options for libedit Currently, building sftp with libedit support assumes that -ledit depends on -lcurses. However, libedit may depend on -lncurses or -ltermcap instead. On SLES 10 for example, libncurses may exist but not libcurses. Perhaps pkg-config should be used to check what libraries are required.
Seems reasonable, however I think it needs to test for the success of "pkg-config --libs-only-l libedit" not just the existence of pkg-config, so it'll still work on systems where libedit is installed but does not have a libedit.pc file (like mine :-).
Created attachment 1832 [details] openssh-libedit-pkgconfig.patch Use pkg-config for libedit only if pkg-config is found, it knows about libedit and --with-libedit does not specify a directory.
Created attachment 1833 [details] Also uses pkg-config for cflags if we decide to use pkg-config. Merge two if blocks into one if/else block.
Thanks all, patch applied and will be in 5.5p1.
Created attachment 1834 [details] openssh-libedit-pkgconfig.patch
Comment on attachment 1834 [details] openssh-libedit-pkgconfig.patch oops, accidentally reran the "bugz" command and reattached this file. please ignore
Mass move of bugs RESOLVED->CLOSED following the release of openssh-5.5p1